Only allow ZDO requests to succeed when a response is received

zigpy / zigpy-znp

TI CC2531, CC13x2, CC26x2 radio support for Zigpy and ZHA

GNU General Public License v3.0

146 stars 40 forks source link

Only allow ZDO requests to succeed when a response is received #190

Closed puddly closed 1 year ago

puddly commented 1 year ago

Should fix https://github.com/home-assistant/core/issues/80519

Z-Stack does not send a "successfully sent" notification for any request to endpoint 0. Instead of assuming the request sent, this change will have zigpy-znp wait for a ZDO response from the device, confirming the packet was actually sent. This is a stronger delivery guarantee than an APS ACK and I'm not 100% sure if it's compatible with all uses of the ZDO endpoint.

MattWestb commented 1 year ago

"Normal" ZDO commands shall not being any problems but in the paring it some cases is little different with unicat and acks so testing if paring working OK is the only way (i think real Zigbee 3 and old HA and ZLL pairing can being needed testing).