zigpy / zigpy-znp

TI CC2531, CC13x2, CC26x2 radio support for Zigpy and ZHA
GNU General Public License v3.0
146 stars 40 forks source link

Keep track of what retry method actually works #216

Closed puddly closed 1 year ago

puddly commented 1 year ago

I'd like to reduce the number of internal retries: 5 is a little excessive. To keep track of which ones work I've added some global counters for each one. These counters will be present in the ZHA diagnostic JSON.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 :warning:

Comparison is base (c4db8d1) 98.54% compared to head (6cd3e60) 98.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #216 +/- ## ========================================== - Coverage 98.54% 98.51% -0.03% ========================================== Files 43 43 Lines 3773 3780 +7 ========================================== + Hits 3718 3724 +6 - Misses 55 56 +1 ``` | [Impacted Files](https://app.codecov.io/gh/zigpy/zigpy-znp/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [zigpy\_znp/zigbee/application.py](https://app.codecov.io/gh/zigpy/zigpy-znp/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-emlncHlfem5wL3ppZ2JlZS9hcHBsaWNhdGlvbi5weQ==) | `95.17% <100.00%> (+0.08%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/zigpy/zigpy-znp/pull/216/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.