search

zigpy / zigpy-znp

TI CC2531, CC13x2, CC26x2 radio support for Zigpy and ZHA
GNU General Public License v3.0
150 stars 40 forks source link

Support Codecov v4 changes #245

Closed TheJulianJES closed 7 months ago

TheJulianJES commented 7 months ago

DRAFT -- do not merge yet (needs below workflow PR merged first, CI will fail for now)

Passes the CODECOV_TOKEN GH secret to the shared workflow. Related PR with more information:

TheJulianJES commented 7 months ago

The Python test failure is unexpected/unrelated. I'll get all other PRs done first and then take a look at this. Since it's unrelated, we could still consider merging this anyway to have Codecov working on the PR that fixes the Python tests.

TheJulianJES commented 7 months ago

Seems to break with zigpy 0.60.3 already. Both caused by (at least):

(still taking a look for now)

puddly commented 7 months ago

Ah, you're right. We don't run CI on radio libraries when making zigpy changes and ZNP hasn't needed any since December! Perhaps that would be something to explore in the future.

TheJulianJES commented 7 months ago

https://github.com/zigpy/zigpy-znp/pull/246 should fix the test issues. CI won't work on that at all right now, so I'll merge this Codecov PR as-is, then rebase the test fix PR and merge that (and have a green tree again).