search

zigpy / zigpy-znp

TI CC2531, CC13x2, CC26x2 radio support for Zigpy and ZHA
GNU General Public License v3.0
144 stars 40 forks source link

Fix tests broken by zigpy update #246

Closed TheJulianJES closed 2 months ago

TheJulianJES commented 2 months ago

This fixes tests that were broken by zigpy 0.60.3 (and later).

For the watchdog change, we can also only move the startup phase (where the watchdog loop gets started) into where the period is patched: https://github.com/zigpy/zigpy-znp/commit/464a9fffc8b2db54cc3ea230496ba8896364433a, but we might as well patch the period for the entire test (which I did for now). Or is there another preferred way to do it?

cc @puddly

Depending on how GitHub actions work, we might want to merge https://github.com/zigpy/zigpy-znp/pull/245 first to have CI working. EDIT: Yeah, looks like CI doesn't start at all, so am I fine to merge that Codecov CI first?

puddly commented 2 months ago

am I fine to merge that Codecov CI first?

Sure, go for it!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.10%. Comparing base (e3c9fcf) to head (3051bbe). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #246 +/- ## ======================================= Coverage 98.10% 98.10% ======================================= Files 43 43 Lines 3647 3647 ======================================= Hits 3578 3578 Misses 69 69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.