search

zigtools / zls-vscode

Deprecated, please use https://github.com/ziglang/vscode-zig
https://github.com/ziglang/vscode-zig
MIT License
85 stars 15 forks source link

Update dependencies #33

Closed ryuukk closed 2 years ago

ryuukk commented 2 years ago

This will be required in order to be able to support latest features of LSP (like labelDetails)

It's not ready to get merged because there is a bug in ZLS

Removing this field fixes the issue: https://github.com/zigtools/zls/blob/fc5b1c64579e0ec33ea374051bcfef59ebfc0c5c/src/types.zig#L245

Something about ranges is wrong, i tried to investigate today, but i couldn't find the cause, so i just commented that line.. so far it seems to be ok

I'll try to spend more time on it tomorrow, since i need that to get sorted out to be able to send a PR to add labelDetails support

SuperAuguste commented 2 years ago

LGTM, thank you so much! Yeah, ranges are always a pain point, best of luck figuring them out. <3