Bug in identifier detection

[Sekky61]

Zig Version

0.14.0-dev.1573+4d81e8ee9

ZLS Version

0.14.0-dev.160+cf9b49a

Client / Code Editor / Extensions

NVIM v0.10.1 and lspconfig

Steps to Reproduce and Observed Behavior

const std = @import("std");
const print = std.debug.print;

const Enum = enum {
    source,
    @"source.fixAll",
};

pub fn main() void {
    const @"identifier with spaces in it" = Enum.source;

    switch (@"identifier with spaces in it") {
        .source => print("abc\n", .{}),
        .@"source.fixAll" => print("abcd--\n", .{}),
    }
}

Reproduction:

1. Hover over the @"identifier with spaces in it" and perform Go to definition
2. Hover over the word source in .@"source.fixAll" and perform Go to definition
3. Hover over the word fixAll in .@"source.fixAll" and perform Go to definition

Notice that:

• The go to definition does not work for the variable in the switch statement.
• The go to definition on the .@"source.fixAll" jumps to the source definition and only works before the dot.

Expected Behavior

I expected the cursor to go to the definition of the variable/enum variant.

Relevant log output

No response

[Sekky61]

As for the fix, the problem seems to be in the identifierLocFromIndex function. It does not work with identifiers with special characters (the @"" syntax).

I propose that identifierLocFromIndex should handle the @"" syntax. If you agree, I would like to take a look at this issue