search

zigwasm / wasmtime-zig

Zig embedding of Wasmtime
Apache License 2.0
82 stars 8 forks source link

Rename anyref #12

Closed protheory8 closed 3 years ago

protheory8 commented 3 years ago

anyref is no longer called so, it was changed to externref some time ago.

Luukdegram commented 3 years ago

I assume you're talking about the valkind enum tag. Those names are from the C headers where they're still called anyref and funcref so I kept to that naming convention until they're updated as well. Perhaps it's worth it to rename it prematurely and keep closer to the spec, but naming isn't too high on my to-do list right now. Feel free to submit a PR if this is important to you.

protheory8 commented 3 years ago

I didn't realize that they were still called like that in the C API proposal, sorry for bothering.

Luukdegram commented 3 years ago

No worries! Something like this is easy to be missed so I appreciate the headsup :)