search

zigzap / zap

blazingly fast backends in zig
MIT License
1.98k stars 71 forks source link

simple router with handler clojures support #68

Closed StringNick closed 5 months ago

renerocksai commented 5 months ago

Thanks, that's a great PR; I like the example. I hope I'll have more time later to look at it more closely before merging. I'd recommend naming it differently, more descriptively than hello3. Maybe something that communicates mapping routes to handler functions?

Also, please add it to the list of examples in the README, with a short description.

It's a really great example! Also, the self hack is genius! :+1:

renerocksai commented 5 months ago

oh, why not name it simple-router?

StringNick commented 5 months ago

thank you for review and comments, i will fix it, first version name was SimpleRouter, but i saw u refactored names and renamed too, will use SimpleRouter

renerocksai commented 5 months ago

Thx for the great work. Now, if you're up for it, could you please add doc comments for the zap.Router? Best take the zig-0.12.0 branch for that, as I fixed some const issues there (new zig is const-mad).