search

zigzap / zap

blazingly fast backends in zig
MIT License
1.98k stars 71 forks source link

1.fix 0.12.0-dev.2334+aef1da163 build #87

Closed funnywwh closed 3 months ago

funnywwh commented 3 months ago

fix zig version 0.12.0-dev.2334+aef1da163 error

renerocksai commented 3 months ago

Hi and thanks for all the work. It's a bit unfortunate because the readme is pretty clear about this. There is a reason why releases (and master) are zig 0.11.0. That's an LTS feature for users with zap in production.

There is a zig-0.12.0 branch which has many of the changes you made already. Most recent changes to the ever-changing std.http (for testing and announceybot) I haven't had time for porting yet.

If your PR (which is likely but I haven't checked yet) also addresses those recent std.http changes, I will reuse the associated change hunks fro your PR.

If you have any suggestions for making it even more clear in the readme that zap is tied to zig releases (!) but that there is likely to always be an integration branch with current zig master, I am open to suggestions. I just don't want an entire screen full of this stuff

renerocksai commented 3 months ago

Feel free to also jump into discord, I've started a thread there. It's suboptimal if your energy is "wasted". Maybe the project can do sth to at least avoid that in the future.

funnywwh commented 3 months ago

ok,i will try to merge to branch zig.0.12.0.Sorry,I didn't see the zig.0.12.0 branch.