zijiechenrobotics / ig_lio

iG-LIO: An Incremental GICP-based Tightly-coupled LiDAR-inertial Odometry
GNU General Public License v2.0
390 stars 53 forks source link

save result/log when installed with cmake #9

Closed juliangaal closed 8 months ago

juliangaal commented 8 months ago

When using catkin_make install (see #8), the result folder does not exist.

This PR:

Please let me know if everything worked out for you, I verified with NCD.

zijiechenrobotics commented 8 months ago

Thanks for your PR! But I think Cmakelist.txt should include

install(DIRECTORY rviz/
  DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}/rviz
  PATTERN ".svn" EXCLUDE)

Otherwise, RViz will not be able to visualize.

I will fix this bug myself after merging your PR. Thanks again for your contribution to iG-LIO. 🥰

juliangaal commented 8 months ago

No problem, and you are right