search

zikaari / monaco-editor-textmate

MIT License
122 stars 16 forks source link

Broken identifier highlighting #26

Open souporserious opened 1 year ago

souporserious commented 1 year ago

First, thank you so much for the work on this project! I haven't been able to get any other solutions working for TextMate grammars besides this library.

I'm running into a weird issue that I was able to trace to the 0.30.0 of monaco-editor. Moving between both of the versions will produce the following inconsistencies when highlighting identifiers in certain cases:

Before 0.29.1

image

After 0.30.0

image

I'm not entirely sure how all of the highlighting is working and wish I could provide more information. It's not clear either why things started breaking between those two versions as the changes seem unrelated.

This repo showcases the issue in a previous commit here. I've fixed the version (managed by @monaco-editor/loader) to get around the issue for now.

zikaari commented 1 year ago

Hi Travis, I wish I could help you, but I have been out of touch with this library (and other sibling libraries that I have) for 4 years now. I'm happy to approve any pull request and re-publish it on NPM if you're willing to take this on. Cheers.

souporserious commented 1 year ago

No worries, totally understand. I appreciate the response! I've been actively trying to find a solution and will post a PR if I can come up with anything.