search

zikaari / monaco-editor-textmate

MIT License
122 stars 16 forks source link

Export TokenizerState class #4

Closed paul-marechal closed 6 years ago

paul-marechal commented 6 years ago

I don't know if it is such a good idea, but I was trying to define my own tokenizer using your package, but the TokenizerState class is not exported. I was just hoping I could import it instead of having to write something that would do exactly what you already did :)

(I don't know how the copyrights would play here, so I would prefer having you exporting the class)

zikaari commented 6 years ago

Will do certainly.

Expect a patch later today

zikaari commented 6 years ago

I saw one of your pull requests in theia repo where had a workaround. Is this still necessary?

paul-marechal commented 6 years ago

I made a workaround indeed, doesn't mean this wouldn't benefit someone though :)

zikaari commented 6 years ago

Hopefully monaco-editor adds support for scopeName arrays soon, then monaco-editor-textmate will work out of the box anyway; without additional hacking.

Consider bumping https://github.com/Microsoft/monaco-editor/issues/929

cc Theia contributors @marechal-p @epatpol @svenefftinge @mofux