search

zikaari / monaco-textmate

MIT License
81 stars 10 forks source link

Thank you for this package Neek! #9

Open miketromba opened 3 years ago

miketromba commented 3 years ago

Thank you for this package Neek, it is the only Monaco + Textmate solution I was able to properly get up and running.

I'm using it to build the VS Code Theme Editor (post about it here), and this is extremely helpful!

One thing I wanted to let you know is that the current package does not work with the latest version of monaco-editor. I had to revert monaco-editor to version 0.19.x in order to get it properly working. The Monaco API has changed a little since you first released this.

Additionally, after using your monaco-vscode-textmate-theme-converter plugin, the syntax appeared like this:

image

In order to get it looking like the actual theme, I had to add two rules to the generated Monaco theme file which define the editor's background color, and the default text color:

image

After making these tweaks, here is the final result of how the syntax looks:

image

I might suggest adding info to the readmes about these two issues.

Thanks again Neek!

zikaari commented 3 years ago

You're welcome mate! You just made my day. I'm really busy with other things at the moment, would you be willing to send in a PR that updates it to the newer API? (it's ok if you don't have time either)

@CompuIves is codesandbox still based on monaco-textmate? If so how are you guys dealing with this problem of version incompatibility?

miketromba commented 3 years ago

PR Submitted: https://github.com/NeekSandhu/monaco-editor-textmate/pull/16 *The change might be breaking for dependents using monaco-editor <0.21