zikaari / react-aspen-demo

Example filetree component for React apps based on `react-aspen`
https://neeksandhu.github.io/react-aspen-demo/
MIT License
11 stars 10 forks source link

Awesome demo, but.... #3

Open MikeWarren2014 opened 4 years ago

MikeWarren2014 commented 4 years ago

This is a really great demo. It looks quite promising, in that it doesn't render child elements.

Right now, at my work, we have some pages that have recursive structures (e.g. stores with stations), and have our own way of doing it, but it seems (dare I say it, a bit naive). I think your way is better.

However, when testing by expanding the file tree past its container, I saw we were still rendering that other stuff. Is there way to not render anything past the container?

Again, this is awesome plugin and I look forward to using it.

zikaari commented 4 years ago

Can you please explain what are you referring to with "other stuff"?

A screenshot with annotations might help.

MikeWarren2014 commented 4 years ago

The screenshot will have to come later in the day (it's 4:52am here in Indy), but I basically did the following:

I saw all the DOM elements for all the items, instead of just the visible ones in the window.