search

zikula-modules / DizkusModule

Official repository for Dizkus, a fully integrated forum solution for Zikula 1.4+
21 stars 7 forks source link

V4 hooks #317

Closed Kaik closed 7 years ago

Kaik commented 7 years ago

Base topic provider and hook settings.

300 #316

craigh commented 7 years ago

I've hope you've read this: https://github.com/zikula/core/tree/master/src/docs/Hooks

specifically this: https://github.com/zikula/core/blob/master/src/docs/Hooks/2.TaggedHookServices.md

regarding "Tagged Hook Services" and not using persisted hooks.

Kaik commented 7 years ago

Well, yes I'm aware of those changes this is:

  1. Zikula 1.4.x version should work on 1.5
  2. I will go into this again for core 2.0 I expect some things to change.

Which way of merge should I chose so it will be easy to propagate those changes into higher versions? squash and merge ?

craigh commented 7 years ago

you can merge however you like. it is only a timeline difference.

my point was that if you are into now, you should make the changes now unless you are working for 1.4 compatibility

Kaik commented 7 years ago

Yes this is 1.4 for 2.0 it would be easier to do this :) anyway this one will stay for 1.4 I will try to merge it with version for 2.0 and then update to new but first I need to finish hooks import, then forum moderation and all missing stuff for 1.4/1.5... then I will move to 2.0 and new features.

Kaik commented 7 years ago

It might fail on install/upgrade I'm working on this now.