search

zikula-modules / Pages

Simple HTML Pages
https://ziku.la/
18 stars 4 forks source link

Installation issues. #118

Closed paustian closed 3 years ago

paustian commented 3 years ago

In trying to upgrade from Pages 3.2.3 to 4.1.0 I ran into a few small issues.

  1. Line 96 of PagesModuleInstaller, the value sent to setCounter has to be cast as an int. Here is the fix: $page->setCounter((int)$row['counter']);

  2. Argument 1 passed to Zikula\PagesModule\Entity\Base\AbstractPageEntity::setPageLanguage() must be of the type string, bool given. The fix is: $page->setPageLanguage((string) $row['language']);

Finally, after installation, it reports an invalid route for Pages. Not sure what the issue is here, but the Module is unuseable in this state. Even with a clean install I get this issue.

Guite commented 3 years ago

Added the small fixes in https://github.com/zikula-modules/Pages/commit/4480a81e3c04725637f9edc00de3b028e3966fcd

No idea though why it tries to create the zikula_pages_page table twice. Is it possible that this is only a result from your multiple test runs?

paustian commented 3 years ago

Yeah it was a results of the multiple test runs.

Guite commented 3 years ago

Thank you @paustian !

paustian commented 3 years ago

Those changes in 4480a81 fixed the upgrade issues. However I am still having the routes problem

Guite commented 3 years ago

Oh, didn't see this part of the problem description. Did you try renewing the routes in the Routes module's administration?

paustian commented 3 years ago

Just saw this now. That doesn't help. I also tried deleting the cache. No luck. The module is installing funky static routes. /pages/pages /pages/admin/page etc.

Guite commented 3 years ago

Please try changing to dev environment. Does this make a change?

paustian commented 3 years ago

No route found for: Get:/pages I left it open so you can see the results Go here https://fourthedition.theorygizmos.com/pages