use DoctrineExtensions\Paginate\Paginate; does not work

[cmfcmf]

Using a MOST 1.3.5 module, it has the use statement you see above in his Entity Repository. But this gives an error: Fatal error: Class 'DoctrineExtensions\Paginate\Paginate' not found in src/modules/testmod/lib/testmod/Entity/Repository/Base/Test.php on line 434

This is because the DoctrineExtensions of the vendor "beberlei" are missing.

[Guite]

In 1.3.6 there are other classes which must/should be used instead. Background is that a newer Doctrine version is used.

More information here:

• https://github.com/Guite/MostGenerator/blob/master/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/zclassic/models/Repository.xtend#L107
• http://docs.doctrine-project.org/en/latest/tutorials/pagination.html
• https://github.com/Guite/MostGenerator/blob/master/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/zclassic/models/Repository.xtend#L729
• https://github.com/Guite/MostGenerator/blob/master/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/zclassic/models/Repository.xtend#L765

Seems to be a similar situation like the updated Sluggable behaviour (means a BC break here).

[cmfcmf]

Adding "beberlei/DoctrineExtensions": "dev-master" to composer solves the problem. I'm not sure why it is not in there @drak.

Edit: Thank you @Guite.

[ghost]

@cmfcmf If my memory is right, it's because the paginator functions were added to Doctrine ORM itself making this extension unnecessary, see http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/pagination.html

[cmfcmf]

Yes, but they have different class names: Before: DoctrineExtensions\Paginate\Paginate; Now: Doctrine\ORM\Tools\Pagination\Paginator;

IMHO we should leave this extension in the core for BC reasons.

[ghost]

Ok, but with clear instructions it will be removed in the next major version - i.e. it's now deprecated and must be refactored.

[ghost]

@cmfcmf can you make a PR and include a note in the UPGRADING-1.3.6 documentation.

[cmfcmf]

Doesn't seem to work, I'll check it: http://support.zikula.de/module-CMS_Support_Forum-viewtopic-topic-31278-start-15.htm#pid148652

[craigh]

The pagination in dizkus is working but I don't remember which one it uses.

[ghost]

@cmfcmf specifically what does not work. What error do you get now? This ticket is about a missing class.

[cmfcmf]

I just checked and it works for me under 1.3.6 even with the Eternizer module. @phaidon Please feel free to reopen if it still does not work for you using the latest core.