Closed andre-meneses-fivestars closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: andre-meneses-fivestars
To complete the pull request process, please assign simfg after the PR has been reviewed.
You can assign the PR to them by writing /assign @simfg
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Welcome @andre-meneses-fivestars! It looks like this is your first PR to zilliztech/GPTCache 🎉
There is a better way to fix this from the RedisVectorStore side
@andre-meneses-fivestars the bug has fix in the dev branch. And i will publish a new version
@andre-meneses-fivestars the bug has fix in the dev branch. And i will publish a new version
@SimFG I see you also fixed removing the doc_prefix, which I was going to address next ;) Thank you
Thank your attention and support
@SimFG no problem. Will you update the release on PyPI ?
@andre-meneses-fivestars has released, you can try to install the latest version 0.1.34
@SimFG already installed. You're great!
While testing GPTCache with PostrgreSQL as
cache_base
and RedisVectorStore asvector_base
, along withSearchDistanceEvaluation
assimilarity_evaluation
an error occurs, because the distance value incache_dict
is astr
and then it can't be compared with 0 right from the start.I added a cast to float in order to fix the Bug.