zilliztech / GPTCache

Semantic cache for LLMs. Fully integrated with LangChain and llama_index.
https://gptcache.readthedocs.io
MIT License
6.96k stars 490 forks source link

Support caching of async completion and cache completion #513

Closed Rested closed 10 months ago

Rested commented 11 months ago

415 addresses some of the comments here

sre-ci-robot commented 11 months ago

Welcome @Rested! It looks like this is your first PR to zilliztech/GPTCache 🎉

codecov[bot] commented 11 months ago

Codecov Report

Merging #513 (6fc861e) into dev (a3328f2) will decrease coverage by 0.96%. Report is 13 commits behind head on dev. The diff coverage is 31.37%.

:exclamation: Current head 6fc861e differs from pull request most recent head 69f8378. Consider uploading reports for the commit 69f8378 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/zilliztech/GPTCache/pull/513/graphs/tree.svg?width=650&height=150&src=pr&token=E30WxqBeJJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)](https://app.codecov.io/gh/zilliztech/GPTCache/pull/513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) ```diff @@ Coverage Diff @@ ## dev #513 +/- ## ========================================== - Coverage 94.20% 93.24% -0.96% ========================================== Files 94 94 Lines 3898 3967 +69 ========================================== + Hits 3672 3699 +27 - Misses 226 268 +42 ``` | [Files Changed](https://app.codecov.io/gh/zilliztech/GPTCache/pull/513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) | Coverage Δ | | |---|---|---| | [gptcache/adapter/openai.py](https://app.codecov.io/gh/zilliztech/GPTCache/pull/513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-Z3B0Y2FjaGUvYWRhcHRlci9vcGVuYWkucHk=) | `80.95% <29.16%> (-13.68%)` | :arrow_down: | | [gptcache/adapter/adapter.py](https://app.codecov.io/gh/zilliztech/GPTCache/pull/513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-Z3B0Y2FjaGUvYWRhcHRlci9hZGFwdGVyLnB5) | `87.71% <66.66%> (-0.34%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/zilliztech/GPTCache/pull/513/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)
sre-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rested To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed. You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/GPTCache/blob/dev/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SimFG commented 11 months ago

Thank you for your patience with this pr

Rested commented 11 months ago

Not sure what's up with the last ci fail