zilliztech / GPTCache

Semantic cache for LLMs. Fully integrated with LangChain and llama_index.
https://gptcache.readthedocs.io
MIT License
6.96k stars 490 forks source link

[fix] Failed to import gptcache due to missing redis dependency #522

Closed a9raag closed 11 months ago

a9raag commented 11 months ago

resolves #521

Moved RedisCacheEviction to its own module to avoid calls that tries to import and install redis

codecov[bot] commented 11 months ago

Codecov Report

Merging #522 (09bda62) into dev (790e9f4) will increase coverage by 0.00%. The diff coverage is 92.30%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/zilliztech/GPTCache/pull/522/graphs/tree.svg?width=650&height=150&src=pr&token=E30WxqBeJJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)](https://app.codecov.io/gh/zilliztech/GPTCache/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) ```diff @@ Coverage Diff @@ ## dev #522 +/- ## ======================================= Coverage 93.89% 93.90% ======================================= Files 95 96 +1 Lines 4014 4017 +3 ======================================= + Hits 3769 3772 +3 Misses 245 245 ``` | [Files Changed](https://app.codecov.io/gh/zilliztech/GPTCache/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) | Coverage Δ | | |---|---|---| | [gptcache/manager/eviction/distributed\_cache.py](https://app.codecov.io/gh/zilliztech/GPTCache/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-Z3B0Y2FjaGUvbWFuYWdlci9ldmljdGlvbi9kaXN0cmlidXRlZF9jYWNoZS5weQ==) | `87.50% <ø> (-2.16%)` | :arrow_down: | | [gptcache/manager/eviction/redis\_eviction.py](https://app.codecov.io/gh/zilliztech/GPTCache/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-Z3B0Y2FjaGUvbWFuYWdlci9ldmljdGlvbi9yZWRpc19ldmljdGlvbi5weQ==) | `91.89% <91.89%> (ø)` | | | [gptcache/manager/eviction/manager.py](https://app.codecov.io/gh/zilliztech/GPTCache/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-Z3B0Y2FjaGUvbWFuYWdlci9ldmljdGlvbi9tYW5hZ2VyLnB5) | `100.00% <100.00%> (ø)` | |
a9raag commented 11 months ago

/assign @simfg

SimFG commented 11 months ago

/lgtm /approve

sre-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a9raag, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/GPTCache/blob/dev/OWNERS)~~ [SimFG] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marioluan commented 8 months ago

I still see the issue.