search

zilliztech / GPTCache

Semantic cache for LLMs. Fully integrated with LangChain and llama_index.
https://gptcache.readthedocs.io
MIT License
7.25k stars 507 forks source link

support for lancedb as vectordb #644

Closed akashAD98 closed 2 months ago

akashAD98 commented 2 months ago

added support for lancedb

akashAD98 commented 2 months ago

/assign @xiaofan-luan

SimFG commented 2 months ago

please set the target branch to the dev branch, and fix the lint error

sre-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akashAD98 To complete the pull request process, please ask for approval from simfg after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/GPTCache/blob/dev/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akashAD98 commented 2 months ago

@SimFG i did changes please check it. t hank you for your time

akashAD98 commented 2 months ago

@SimFG can you please help me in this pr? your help would be appreciated thanks.

SimFG commented 2 months ago

@akashAD98 got it, i will check it

SimFG commented 2 months ago

you can try to execute make pylint_check to find the lint error

akashAD98 commented 2 months ago

you can try to execute make pylint_check to find the lint error

yes actually I used it still not sure why its missing even I did respective changes @SimFG