search

zilliztech / VectorDBBench

A Benchmark Tool for VectorDB
MIT License
522 stars 133 forks source link

Send password, batch pipeline #247

Closed ewpreston closed 9 months ago

ewpreston commented 10 months ago

Set default index type to HNSW instead of FLAT so comparisons are fair

Send password when creating connection. The UI requires a password for Redis. Even if no password is set on the Redis database, sending an empty string is fine.

Batch the pipeline.execute calls so we don't run out of memory on the client.

This is for issue #228 https://github.com/zilliztech/VectorDBBench/issues/228

liliu-z commented 10 months ago

/assign @alwayslove2013

alwayslove2013 commented 9 months ago

@tylerhutcherson Could you please help review it ~

tylerhutcherson commented 9 months ago

@tylerhutcherson Could you please help review it ~

Left one more small suggestion for @ewpreston but otherwise LGTM

sre-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ewpreston, tylerhutcherson To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed. You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/VectorDBBench/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alwayslove2013 commented 9 months ago

@ewpreston @tylerhutcherson nice~