search

zilliztech / VectorDBBench

A Benchmark Tool for VectorDB
MIT License
558 stars 151 forks source link

Custom case cli bug, refactoring and README updates. #384

Closed Sheharyar570 closed 3 weeks ago

Sheharyar570 commented 4 weeks ago

This PR includes the following changes.

  1. Fixed custom_case key error in parameters dict in CLI command.
  2. Refactored command options, replaced no-custom-dataset-use-shuffled and no-custom-dataset-with-gt with skip-custom-dataset-use-shuffled and skip-custom-dataset-with-gt for consistency.
  3. Added custom case related command options information.
  4. Added instruction to include custom_case while adding the CLI support for the client.
Sheharyar570 commented 4 weeks ago

/assign @xuanyang-cn

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, Sheharyar570 To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed. You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/VectorDBBench/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment