zilliztech / VectorDBBench

A Benchmark Tool for VectorDB
MIT License
561 stars 151 forks source link

Fix pgvectorivfflat reranking key bug #401

Closed Sheharyar570 closed 2 weeks ago

Sheharyar570 commented 2 weeks ago

Issue: #398

Further related issues fixed: Fixed an issue where quantized_fetch_limit was defaulting to ef_search, which is not applicable to ivfflat.

  1. The default value of quantized_fetch_limit for pgvectorhnsw is now set to the value of ef_search.
  2. For pgvectorivfflat, it’s set to 100 (chosen arbitrarily; users should update this based on their requirements).
Sheharyar570 commented 2 weeks ago

/assign @xuanyang-cn

sre-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, Sheharyar570 To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed. You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/VectorDBBench/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment