zilliztech / knowhere

Knowhere is an open-source vector search engine, integrating FAISS, HNSW, etc.
Apache License 2.0
135 stars 57 forks source link

Add range search capability to indexes with AnnIterator support #508

Closed zhengbuqian closed 3 weeks ago

zhengbuqian commented 4 weeks ago

tested using sparse index.

issue: https://github.com/zilliztech/knowhere/issues/193 /kind: feature

sre-ci-robot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/knowhere/blob/main/OWNERS)~~ [zhengbuqian] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.32%. Comparing base (3c46f4c) to head (948a79e). Report is 15 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/zilliztech/knowhere/pull/508/graphs/tree.svg?width=650&height=150&src=pr&token=zFzHwqHGUr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)](https://app.codecov.io/gh/zilliztech/knowhere/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) ```diff @@ Coverage Diff @@ ## main #508 +/- ## ========================================= + Coverage 0 71.32% +71.32% ========================================= Files 0 67 +67 Lines 0 4429 +4429 ========================================= + Hits 0 3159 +3159 - Misses 0 1270 +1270 ``` [see 67 files with indirect coverage changes](https://app.codecov.io/gh/zilliztech/knowhere/pull/508/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)
zhengbuqian commented 4 weeks ago

/hold It won't compile with swig for now

zhengbuqian commented 4 weeks ago

/hold It won't compile with swig for now

fixing in https://github.com/zilliztech/knowhere/pull/509, will unhold after that is merged.

zhengbuqian commented 4 weeks ago

/unhold

alexanderguzhva commented 3 weeks ago

/lgtm