search

zilliztech / knowhere

Knowhere is an open-source vector search engine, integrating FAISS, HNSW, etc.
Apache License 2.0
135 stars 57 forks source link

merging more changes from the faiss baseline #510

Closed alexanderguzhva closed 3 weeks ago

alexanderguzhva commented 4 weeks ago

Most of the changes are nits and tiny tweaks or code cleanups. There should be nothing groundbreaking. /kind improvement

mergify[bot] commented 4 weeks ago

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.36%. Comparing base (3c46f4c) to head (15fbd12). Report is 16 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/zilliztech/knowhere/pull/510/graphs/tree.svg?width=650&height=150&src=pr&token=zFzHwqHGUr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)](https://app.codecov.io/gh/zilliztech/knowhere/pull/510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) ```diff @@ Coverage Diff @@ ## main #510 +/- ## ========================================= + Coverage 0 72.36% +72.36% ========================================= Files 0 63 +63 Lines 0 4291 +4291 ========================================= + Hits 0 3105 +3105 - Misses 0 1186 +1186 ``` [see 63 files with indirect coverage changes](https://app.codecov.io/gh/zilliztech/knowhere/pull/510/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)
liliu-z commented 3 weeks ago

/lgtm

cydrain commented 3 weeks ago

/approve

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/knowhere/blob/main/OWNERS)~~ [cydrain] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
liliu-z commented 3 weeks ago

/kind improvement