zilliztech / knowhere

Knowhere is an open-source vector search engine, integrating FAISS, HNSW, etc.
Apache License 2.0
135 stars 57 forks source link

sparse float vector index to support mmap when loading from index file #530

Closed zhengbuqian closed 3 weeks ago

zhengbuqian commented 3 weeks ago

issue: https://github.com/milvus-io/milvus/issues/29419

/kind: improvement

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/knowhere/blob/main/OWNERS)~~ [zhengbuqian] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.69%. Comparing base (3c46f4c) to head (8f6c703). Report is 24 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/zilliztech/knowhere/pull/530/graphs/tree.svg?width=650&height=150&src=pr&token=zFzHwqHGUr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)](https://app.codecov.io/gh/zilliztech/knowhere/pull/530?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) ```diff @@ Coverage Diff @@ ## main #530 +/- ## ========================================= + Coverage 0 71.69% +71.69% ========================================= Files 0 67 +67 Lines 0 4431 +4431 ========================================= + Hits 0 3177 +3177 - Misses 0 1254 +1254 ``` [see 67 files with indirect coverage changes](https://app.codecov.io/gh/zilliztech/knowhere/pull/530/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)
alexanderguzhva commented 3 weeks ago

/lgtm