search

zilliztech / knowhere

Knowhere is an open-source vector search engine, integrating FAISS, HNSW, etc.
Apache License 2.0
179 stars 74 forks source link

Don't kill the thread with fixable issue #777

Open liliu-z opened 1 month ago

liliu-z commented 1 month ago

From the code, this error will kill the folly thread, and exception will throw from WaitAllSuccess. Then the catch block outside will catch this error and return an error code to Milvus. User will get error report, do some modification and then retry. But the folly thread is permenentally dead.

  1. If this is an unexpected error, we need to crash the Milvus
  2. If it is a fixable problem (mis operation order, retryable), then we should not kill the thread.

_Originally posted by @liliu-z in https://github.com/zilliztech/knowhere/pull/746#discussion_r1728625505_

liliu-z commented 1 month ago

/assign @alexanderguzhva /assign

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.