search

zilliztech / milvus-backup

Backup and restore tool for Milvus
Apache License 2.0
129 stars 46 forks source link

[FIX]: Empty b.params.MinioCfg.RootPath handler (S3/Ceph) #177

Closed punkerpunker closed 1 year ago

punkerpunker commented 1 year ago

Intended to fix https://github.com/zilliztech/milvus-backup/issues/176

I tested it on my side, that seems to help. Just adding a simple handler for the cases where b.params.MinioCfg.RootPath is empty. Thanks!

sre-ci-robot commented 1 year ago

Welcome @punkerpunker! It looks like this is your first PR to zilliztech/milvus-backup 🎉

mergify[bot] commented 1 year ago

@punkerpunker Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] commented 1 year ago

@punkerpunker Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

wayblink commented 1 year ago

@punkerpunker Hi, there is deltaLogPath needs the same fix. Could you please add it as well?

punkerpunker commented 1 year ago

Added @wayblink, thanks!

sre-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: punkerpunker, wayblink

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/milvus-backup/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment