zilliztech / milvus-backup

Backup and restore tool for Milvus
Apache License 2.0
129 stars 46 forks source link

[Enhancement]: support config milvus form env. #178

Closed xushaoxiao closed 1 year ago

xushaoxiao commented 1 year ago

What would you like to be added?

hello teams,

I recently applied the milvus open source project, and made changes to the source code when deploying the backup. I wanted to submit a pr, but the request was denied. Can invite me to join the contributor.

BR. Shaoxiao.

Why is this needed?

No response

Anything else?

No response

wayblink commented 1 year ago

@xushaoxiao hi, what error you got? It is a public repo, supposed to allow pr from anywhere

wayblink commented 1 year ago

@xushaoxiao I guess you need to folk this repo and submit PR instead of submit to this repo directly

xushaoxiao commented 1 year ago

hi @wayblink , thank you. you are right. i want to submit pr for code review.

xushaoxiao commented 1 year ago

@xushaoxiao I guess you need to folk this repo and submit PR instead of submit to this repo directly

I try push my fix branch, but got "ERROR: Permission to zilliztech/milvus-backup.git denied to xushaoxiao. fatal: Could not read from remote repository."