search

zilliztech / milvus-backup

Backup and restore tool for Milvus
Apache License 2.0
111 stars 38 forks source link

support loading minio and milvus config from env #182

Closed xushaoxiao closed 10 months ago

xushaoxiao commented 10 months ago

Hi milvus team, pr for issue https://github.com/zilliztech/milvus-backup/issues/178.

please review this pr for me, thanks.

sre-ci-robot commented 10 months ago

Welcome @xushaoxiao! It looks like this is your first PR to zilliztech/milvus-backup 🎉

mergify[bot] commented 10 months ago

@xushaoxiao Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] commented 10 months ago

@xushaoxiao Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

xushaoxiao commented 10 months ago

Hi @wayblink , What means about label "do-not-merge/missing-related-issue "? Maybe i need to do more things about this puull request?

sre-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink, xushaoxiao

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/milvus-backup/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment