search

zilliztech / milvus-backup

Backup and restore tool for Milvus
Apache License 2.0
111 stars 38 forks source link

[Typo]: change minio.cloudprovider comments to correctly reflect accepted cloudproviders in config.yaml #258

Closed mcandio closed 6 months ago

mcandio commented 6 months ago

The config files accepts s3 as a cloud provider but params.go expects "aws" instead https://github.com/zilliztech/milvus-backup/blob/52143599b05435cda4fac8266ef0143e19db8d1e/core/paramtable/params.go#L148

It also suggests aliyun but params.go expects ali. https://github.com/zilliztech/milvus-backup/blob/52143599b05435cda4fac8266ef0143e19db8d1e/core/paramtable/params.go#L150

Config.yaml file: https://github.com/zilliztech/milvus-backup/blob/52143599b05435cda4fac8266ef0143e19db8d1e/configs/backup.yaml#L24

wayblink commented 6 months ago

@mcandio Hi, nice catch, I will fix it