search

zilliztech / milvus-backup

Backup and restore tool for Milvus
Apache License 2.0
111 stars 38 forks source link

Update Dockerfile #336

Closed erigo closed 1 month ago

erigo commented 1 month ago

Add MinIO Client for migrating data in each Milvus cluster.

sre-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: erigo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/milvus-backup/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 1 month ago

@erigo Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] commented 1 month ago

@erigo Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

wayblink commented 1 month ago

@erigo Hi, Thanks for contribution. Why we need that?

wayblink commented 1 month ago

@erigo I get your point, good for now. We will support cross storage backup in our roadmap. Then you will not need to use mc client to copy to local. How about the image size change after you add mc client.

erigo commented 1 month ago

image size from 41.7MB to 68.2MB.

wayblink commented 1 month ago

@erigo Merged.