search

zilliztech / milvus-backup

Backup and restore tool for Milvus
Apache License 2.0
136 stars 50 forks source link

[Feature]: crossStorage backupMinio cmd parameters #419

Closed MatanAmoyal1 closed 2 months ago

MatanAmoyal1 commented 2 months ago

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like.

Hi, As the crossStorage option was added in the last release, I would like to request the addition of command-line parameters related to crossStorage Minio backup, similar to those already existing for Minio (such as MINIO_ACCESS_KEY, MINIO_SECRET_KEY, etc.).

https://github.com/zilliztech/milvus-backup/blob/main/core/paramtable/base_table.go#L411-L464

Describe an alternate solution.

No response

Anything else? (Additional Context)

example: MINIO_BACKUP_ACCESS_KEY => minio.backupAccessKeyID MINIO_BACKUP_SECRET_KEY => minio.backupSecretAccessKey ...

oelezra commented 2 months ago

Interesting

gmoshiko-work commented 2 months ago

we cant move it to production without this feature!

wayblink commented 2 months ago

@MatanAmoyal1 @oelezra @gmoshiko-work Hi, glad to hear you are using this feature in production. This is a reasonable need. I think it is easy to support. I will appreciate it if you can make a contribution.

MatanAmoyal1 commented 2 months ago

@wayblink thanks for your answer. I open new PR, please review :) https://github.com/zilliztech/milvus-backup/pull/420

wayblink commented 2 months ago

@MatanAmoyal1 Merged. Thanks for your PR.

MatanAmoyal1 commented 2 months ago

@wayblink Thanks! What is the plan for the next release includes this change?

wayblink commented 2 months ago

@MatanAmoyal1 Hi, v0.4.22 is released. https://github.com/zilliztech/milvus-backup/releases/tag/v0.4.22

wayblink commented 2 months ago

close as completed