zilliztech / milvus-helm

Apache License 2.0
58 stars 43 forks source link

Fix configmap display chaos #103

Closed tosone closed 4 months ago

tosone commented 4 months ago

What this PR does / why we need it:

在部署完成之后由于 configmap 中的一些值为空,使得 configmap 中的格式变得很混乱,导致无法正常查看。 这里将值为空的值不再渲染。

目前部署完成之后的效果如下:

image

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

sre-ci-robot commented 4 months ago

Welcome @tosone! It looks like this is your first PR to zilliztech/milvus-helm 🎉

tosone commented 4 months ago

@LoveEachDay PTAL

haorenfsa commented 4 months ago

Hi @tosone, I'm confused about what the issue is. Is the snapshot you provided before the change or after the change? If is before, then it looks fine to me.

By the way, fields in .Values.externalS3.xxx should be kept.

tosone commented 4 months ago

Before:

image

After:

image
haorenfsa commented 4 months ago

/approve

sre-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, tosone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-helm/blob/master/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
haorenfsa commented 4 months ago

It's good to merge, thank you @tosone !

haorenfsa commented 4 months ago

/lgtm