zilliztech / milvus-helm

Apache License 2.0
54 stars 41 forks source link

Fix template helper file #104

Closed tosone closed 1 month ago

tosone commented 2 months ago

What this PR does / why we need it:

修复 helper 中的一些明显错误,添加 helper 中引用但是在 values.yaml 中不存在的 nameOverridem, fullnameOverride

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

tosone commented 2 months ago

@LoveEachDay PTAL

haorenfsa commented 2 months ago

@tosone Please also bump the chart version.

haorenfsa commented 1 month ago

/approve

haorenfsa commented 1 month ago

/lgtm

sre-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, tosone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-helm/blob/master/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment