Closed jubingc closed 1 month ago
Welcome @jubingc! It looks like this is your first PR to zilliztech/milvus-helm 🎉
@jubingc Thank you for bringing this patch! Please sign of your commits before we could merge it. see: https://github.com/zilliztech/milvus-helm/pull/138/checks?check_run_id=32317349030
@jubingc Thank you for bringing this patch! Please sign of your commits before we could merge it. see: https://github.com/zilliztech/milvus-helm/pull/138/checks?check_run_id=32317349030
Thanks for the pointer. Commits have been signed off now.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: haorenfsa, jubingc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
To support datadog container autodiscovery, we need annotations attached directly to pods. The existing helm chart only supports custom annotations attached to services.
https://docs.datadoghq.com/containers/kubernetes/prometheus/
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)