Refine etcd probe timeout

zilliztech / milvus-helm

Apache License 2.0

56 stars 43 forks source link

Refine etcd probe timeout #29

Closed LoveEachDay closed 1 year ago

LoveEachDay commented 1 year ago

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ x] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [mychartname])
[ ] PR only contains changes for one chart

LoveEachDay commented 1 year ago

By default, etcd pod has readinessProbe and livenessProbe which are all exec probe. Kubelet will try to fork a process to execute the healthcheck.sh. And in the healthcheck.sh, it will invoke etcdctl endpoint health which has default timeout to 5s. And our probe timeout is 5s default, so if the etcdctl commands needs more time, the healthcheck.sh process is killed, leaving the zoobie etcdctl process.

sre-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bennu-Li, locustbaby, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-helm/blob/master/OWNERS)~~ [LoveEachDay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

Bennu-Li commented 1 year ago

/lgtm /approved

LoveEachDay commented 1 year ago

Fix https://github.com/milvus-io/milvus/issues/27544