[milvus] add Deployment strategy configuration

zilliztech / milvus-helm

Apache License 2.0

56 stars 43 forks source link

[milvus] add Deployment strategy configuration #56

Closed Archalbc closed 8 months ago

Archalbc commented 9 months ago

What this PR does / why we need it:

Allow to specify the Deployment' strategy for "node" components (indexNode, queryNode, dataNode, proxyNode). Usefull when you want more control on the RollingUpdate process (maxUnavailable, maxSurge...).

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [mychartname])
[x] PR only contains changes for one chart

haorenfsa commented 8 months ago

Hi @Archalb Thank you for providing this patch! Before we could merge it, please rebase the current master and bump the chart version again.

Archalbc commented 8 months ago

Hi @Archalb Thank you for providing this patch! Before we could merge it, please rebase the current master and bump the chart version again.

Done! Thank you :)

haorenfsa commented 8 months ago

/lgtm

sre-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Archalbc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/milvus-helm/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment