Closed mchtech closed 4 months ago
Welcome @mchtech! It looks like this is your first PR to zilliztech/milvus-helm 🎉
Hi @mchtech, sry for the delay. Please also bump the version before we could merge it.
Hi @mchtech, sry for the delay. Please also bump the version before we could merge it.
branch synced.
@mchtech, sry I missed last version. Please bump the version again. Thank you very much for your patience!
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: haorenfsa, mchtech
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@mchtech, sry I missed last version. Please bump the version again. Thank you very much for your patience!
branch synced.
/lgtm
What this PR does / why we need it:
metadata.namespace
is missing in some templates.this is needed for when helm is used purely as a templating tool, since helm template does not add the namespace https://github.com/helm/helm/issues/3553
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)