zilliztech / milvus-helm

Apache License 2.0
58 stars 43 forks source link

add namespace metadata #72

Closed mchtech closed 4 months ago

mchtech commented 8 months ago

What this PR does / why we need it:

metadata.namespace is missing in some templates.

this is needed for when helm is used purely as a templating tool, since helm template does not add the namespace https://github.com/helm/helm/issues/3553

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

sre-ci-robot commented 8 months ago

Welcome @mchtech! It looks like this is your first PR to zilliztech/milvus-helm 🎉

haorenfsa commented 4 months ago

Hi @mchtech, sry for the delay. Please also bump the version before we could merge it.

mchtech commented 4 months ago

Hi @mchtech, sry for the delay. Please also bump the version before we could merge it.

branch synced.

haorenfsa commented 4 months ago

@mchtech, sry I missed last version. Please bump the version again. Thank you very much for your patience!

haorenfsa commented 4 months ago

/approve

sre-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, mchtech

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-helm/blob/master/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mchtech commented 4 months ago

@mchtech, sry I missed last version. Please bump the version again. Thank you very much for your patience!

branch synced.

haorenfsa commented 4 months ago

/lgtm