search

zilliztech / milvus-helm

Apache License 2.0
58 stars 43 forks source link

[Enhancement] Etcd podDisruptionBudget selection based on Kubernetes Version #82

Open Rachit-Chaudhary11 opened 8 months ago

Rachit-Chaudhary11 commented 8 months ago

What this PR does / why we need it:

Higher versions of Kubernetes fail to work with etcd's: policy/v1beta1, hence a configurable policy based on the kubernetes version is needed.

Error Message: No matches for kind "PodDisruptionBudget" in version "policy/v1beta1". Reference PR: https://github.com/zilliztech/milvus-helm/pull/74

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

sre-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rachit-Chaudhary11 To complete the pull request process, please assign loveeachday after the PR has been reviewed. You can assign the PR to them by writing /assign @loveeachday in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/milvus-helm/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Rachit-Chaudhary11 commented 8 months ago

Reference PR : https://github.com/zilliztech/milvus-helm/pull/74

Rachit-Chaudhary11 commented 8 months ago

@LoveEachDay @haorenfsa kindly take a look at this PR

haorenfsa commented 7 months ago

Hi team, can I get some updates on this PR?

@Rachit-Chaudhary11 Hi, sry for the delay. The teem are busy with other stuff. Still, as I mentioned in #74, I insist on maintaining the etcd chart code within this repo like we're doing for MinIO. I shall launch another PR to do that. And I think we could merge this PR afterwards.

Thank you again for your contribution.

We are awaiting for this fix as it will cause an issue during our migration ot latest milvus instance

You can solve this by walkaround make a milvus-helm chart package of your own repo.

haorenfsa commented 7 months ago

/assign