zilliztech / milvus-migration

14 stars 2 forks source link

[LICENSE] please mention sbinet/npyio #73

Closed sbinet closed 7 months ago

sbinet commented 7 months ago

Current Behavior

currently, the file under milvus-migration/core/transform/numpy/convert.go contains huge swath of (almost not modified) code coming from:

the LICENSE of sbinet/npyio allows for code copying (it's BSD3) but, as stated in the LICENSE file: https://github.com/sbinet/npyio/blob/main/LICENSE

    * Redistributions of source code must retain the above copyright
      notice, this list of conditions and the following disclaimer.

please add the following blurb to your numpy/convert.go file:

// Copyright 2016 The npyio Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

or somewhere else relevant.

thanks a lot.

@Thomas-HuWei @xiaocai2333

Expected Behavior

correct licensing attributions.

xiaofan-luan commented 7 months ago

Sure thing. We will definitely add it back

Thomas-HuWei commented 7 months ago

@sbinet Thanks for your issue, I've add the LICENSE comment to the file: https://github.com/zilliztech/milvus-migration/pull/74/files