search

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
45 stars 23 forks source link

Fix dynamic config for milvus 2.4, add log when pod template changed #115

Closed haorenfsa closed 4 months ago

haorenfsa commented 4 months ago

Fix #113

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.22%. Comparing base (b660ccc) to head (dbff365). Report is 1 commits behind head on main.

Files Patch % Lines
pkg/controllers/k8s_default_values.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #115 +/- ## ======================================= Coverage 82.21% 82.22% ======================================= Files 54 54 Lines 4932 4934 +2 ======================================= + Hits 4055 4057 +2 - Misses 692 693 +1 + Partials 185 184 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sre-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [LoveEachDay,haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment