zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
45 stars 23 forks source link

External Kafka SASL_SSL is using TLS true #118

Open navneetrajput06 opened 4 months ago

navneetrajput06 commented 4 months ago

Hi Team,

When we are using SASL_SSL for external kafka its expecting tls configuration rather it should go pass with SASL user based authentication only. please check the below snapshot and from the link. looks like we need to remove this piece of code.

https://github.com/zilliztech/milvus-operator/blob/main/pkg/external/kafka.go Screenshot 2024-05-20 at 10 16 35 AM

navneetrajput06 commented 4 months ago

Below is the kafka configuration. its going good in case of PLAINTEXT but expecting TLS in case of SALS_SSL.

Screenshot 2024-05-20 at 10 22 43 AM
haorenfsa commented 4 months ago

@navneetrajput06 em... correct me if I'm wrong: SSL is just an old name of TLS see https://www.cloudflare.com/learning/ssl/transport-layer-security-tls/ . So just as the names suggests, if you only need SASL, then you can use SASL_PLAINTEXT; and if you need SASL together with TLS, then you can use SASL_SSL.