zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
33 stars 20 forks source link

Fix resume a stopped instance when enable hpa #119

Closed haorenfsa closed 1 month ago

haorenfsa commented 1 month ago

/cc @samhuang-z @LoveEachDay

sre-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
samhuang-z commented 1 month ago

/lgtm

sre-ci-robot commented 1 month ago

@samhuang-z: changing LGTM is restricted to collaborators

In response to [this](https://github.com/zilliztech/milvus-operator/pull/119#issuecomment-2124326016): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.23%. Comparing base (c9d72b3) to head (25554bd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ========================================== + Coverage 82.22% 82.23% +0.01% ========================================== Files 54 54 Lines 4934 4937 +3 ========================================== + Hits 4057 4060 +3 Misses 693 693 Partials 184 184 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.