zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
55 stars 25 forks source link

milvus operator is difficult to install as a dependent chart due to the inconsistent use of `release.Name` and `release.FullName` #135

Open butler54 opened 5 months ago

butler54 commented 5 months ago

I wanted to install milvus for various reasons as a dependent chart e.g.

milvus/
milvus/Chart.yaml
milvus/values.yaml

where: Chart.yaml

apiVersion: v2
name: milvus
description: A Helm chart deploying milvus via the operator

type: application
version: 0.1.0
appVersion: "1.0.0"

dependencies:
- name: milvus-operator
  version: "0.9.16"
  repository: "https://zilliztech.github.io/milvus-operator/"

values.yaml

is empty.

The problem is Release.fullName becomes milvus-milvus-operator and release.Name becomes milvus.

This results in inconsistencies around the Certificate generated. The only way to make this work is to set the following in values.yaml

milvus-operator:
  fullnameOverride: "milvus"
haorenfsa commented 5 months ago

Hi @butler54, thank you for feedback! We'll fix this later. Or if you'd like to, you may could open a PR to fix this.