search

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
45 stars 23 forks source link

feat:support headless service for proxy component #138

Closed qchenzi closed 2 months ago

sre-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qchenzi To complete the pull request process, please assign loveeachday after the PR has been reviewed. You can assign the PR to them by writing /assign @loveeachday in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sre-ci-robot commented 3 months ago

Welcome @qchenzi! It looks like this is your first PR to zilliztech/milvus-operator 🎉

haorenfsa commented 3 months ago

Instead of changing current service update function, I suggest adding a new one when headless is enabled. And an option to enable headless service is also needed.

haorenfsa commented 2 months ago

Hi @qchenzi, do you still intend to add this patch ?

qchenzi commented 2 months ago

Hi @haorenfsa

I have decided not to proceed with adding this patch at this time. Thank you for your guidance and support throughout this process. I may revisit this in the future if the need arises.

Best regards