zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
45 stars 23 forks source link

All components support 2 deployment rolling #142

Closed haorenfsa closed 3 months ago

haorenfsa commented 3 months ago

/cc @zwd1208

sre-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 89.09853% with 52 lines in your changes missing coverage. Please review.

Project coverage is 82.05%. Comparing base (e5f665d) to head (7fa913c).

Files Patch % Lines
pkg/controllers/deploy_ctrl_factory.go 0.00% 20 Missing :warning:
pkg/controllers/conditions.go 25.00% 7 Missing and 2 partials :warning:
pkg/controllers/setup.go 0.00% 6 Missing :warning:
pkg/controllers/deploy_ctrl_util.go 97.50% 3 Missing and 2 partials :warning:
pkg/controllers/deploy_ctrl.go 94.02% 3 Missing and 1 partial :warning:
pkg/controllers/rollout_util.go 92.72% 2 Missing and 2 partials :warning:
pkg/controllers/components.go 66.66% 1 Missing and 1 partial :warning:
pkg/controllers/component_condition.go 75.00% 0 Missing and 1 partial :warning:
pkg/controllers/milvus_controller.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #142 +/- ## ========================================== - Coverage 82.29% 82.05% -0.25% ========================================== Files 54 56 +2 Lines 4954 5049 +95 ========================================== + Hits 4077 4143 +66 - Misses 693 719 +26 - Partials 184 187 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zwd1208 commented 3 months ago

/lgtm