search

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
34 stars 20 forks source link

Fix job template render sa, add test #22

Closed haorenfsa closed 9 months ago

haorenfsa commented 9 months ago

Fix https://github.com/milvus-io/milvus-operator/issues/276

sre-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (03fe03a) 80.16% compared to head (1353a7f) 80.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #22 +/- ## ======================================= Coverage 80.16% 80.16% ======================================= Files 47 47 Lines 4760 4760 ======================================= Hits 3816 3816 Misses 797 797 Partials 147 147 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.