search

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
34 stars 20 forks source link

Support hook.yaml update in ConfigMap #23

Closed mintcckey closed 9 months ago

sre-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mintcckey To complete the pull request process, please assign zwd1208 after the PR has been reviewed. You can assign the PR to them by writing /assign @zwd1208 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 9 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (8c06a63) 80.05% compared to head (24fd332) 80.05%. Report is 9 commits behind head on main.

:exclamation: Current head 24fd332 differs from pull request most recent head f980372. Consider uploading reports for the commit f980372 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== - Coverage 80.05% 80.05% -0.01% ========================================== Files 46 47 +1 Lines 4707 4767 +60 ========================================== + Hits 3768 3816 +48 - Misses 795 803 +8 - Partials 144 148 +4 ``` | [Files](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) | Coverage Δ | | |---|---|---| | [apis/milvus.io/v1beta1/components\_types.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-YXBpcy9taWx2dXMuaW8vdjFiZXRhMS9jb21wb25lbnRzX3R5cGVzLmdv) | `100.00% <ø> (ø)` | | | [apis/milvus.io/v1beta1/milvus\_types.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-YXBpcy9taWx2dXMuaW8vdjFiZXRhMS9taWx2dXNfdHlwZXMuZ28=) | `75.65% <100.00%> (+1.57%)` | :arrow_up: | | [pkg/config/config.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `86.84% <ø> (ø)` | | | [pkg/controllers/components.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2NvbXBvbmVudHMuZ28=) | `89.01% <ø> (-0.22%)` | :arrow_down: | | [pkg/controllers/conditions.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2NvbmRpdGlvbnMuZ28=) | `89.71% <100.00%> (ø)` | | | [pkg/controllers/dependency\_graph.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2RlcGVuZGVuY3lfZ3JhcGguZ28=) | `100.00% <ø> (ø)` | | | [pkg/controllers/deployments.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2RlcGxveW1lbnRzLmdv) | `81.81% <ø> (ø)` | | | [pkg/controllers/status\_cluster.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL3N0YXR1c19jbHVzdGVyLmdv) | `87.24% <100.00%> (ø)` | | | [pkg/external/kafka.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2V4dGVybmFsL2thZmthLmdv) | `100.00% <100.00%> (ø)` | | | [pkg/external/minio.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2V4dGVybmFsL21pbmlvLmdv) | `91.30% <100.00%> (+1.30%)` | :arrow_up: | | ... and [7 more](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/23/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.